Commit graph

4 commits

Author SHA1 Message Date
hc-github-team-tf-provider-devex
070aa52467 Update changelog 2023-10-30 11:44:01 +00:00
Oliver Ford
4dff81de7e
Fix output malformed when wrapper enabled (#367)
* Fix output malformed when wrapper enabled

Presently using a command such as `terraform output -json | jq` does not
work with the wrapper enabled, as it is by default.

In order to consume terraform's output having set it up with this
Action, it is necessary either to disable the wrapper (`with:
terraform_wrapper: false`) or run it in its own Actions step with an
explicit `id` (e.g. `id: foo`) so that it can be referred to and consumed
(`${{steps.foo.outputs.stdout}}` et al.) in later steps.

This seems to be the result of much confusion (issues passim) and is not
at all easy (#338) to debug/diagnose and come to the realisation that
it's due to the wrapper, or even that such a thing exists.

@austinvalle identified the issue as being due to the `@actions/exec`
package writing the spawned command to stdout (along with then its
actual stdout). This has previously been reported upstream in
actions/toolkit#649; I've proposed actions/toolkit#1573 to fix it.

This commit aims to address the issue for `setup-terraform` in the
meantime by silencing `@actions/exec` and then writing out to stdout &
stderr from the listener buffers, which it writes to without this
additional logging.

Closes #20, #80, #85, #149, #338, and probably more.

* add test for stdout with jq

* update test name

* remove debug lines and add changelog

* add additional note about the bug fix to wrapper

---------

Co-authored-by: Austin Valle <austinvalle@gmail.com>
2023-10-27 14:05:58 -04:00
Rui Chen
9507e1d5bb
feat: bump to use node20 runtime (#346)
* feat: bump to use node20 runtime

Signed-off-by: Rui Chen <rui@chenrui.dev>

fix action refs for `actions/reusable-workflows`

Signed-off-by: Rui Chen <rui@chenrui.dev>

* docs: update changelog

Signed-off-by: Rui Chen <rui@chenrui.dev>

* workflows: update `actions/reusable-workflows` to use node20

Signed-off-by: Rui Chen <rui@chenrui.dev>

* chore: update dist file

* clean up PR for merge

* add node version

* update dist

* switch changelog

---------

Signed-off-by: Rui Chen <rui@chenrui.dev>
Co-authored-by: Austin Valle <austinvalle@gmail.com>
2023-10-27 08:55:58 -04:00
SBGoods
eed2545295 Switch to Changie for changelog automation 2023-02-08 15:32:40 -05:00