From 2dfb501e55ea336627b94334408499d904525a00 Mon Sep 17 00:00:00 2001 From: Kazuyoshi Yamasaki <55447682+k-yamasaki-zakisan@users.noreply.github.com> Date: Mon, 29 Jan 2024 16:35:07 +0900 Subject: [PATCH 1/4] update readme actions/checkout to v4 (#390) --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index c5cbc3a..dfe9dbf 100644 --- a/README.md +++ b/README.md @@ -90,7 +90,7 @@ defaults: permissions: pull-requests: write steps: -- uses: actions/checkout@v3 +- uses: actions/checkout@v4 - uses: hashicorp/setup-terraform@v3 - name: Terraform fmt @@ -158,7 +158,7 @@ defaults: permissions: pull-requests: write steps: -- uses: actions/checkout@v3 +- uses: actions/checkout@v4 - uses: hashicorp/setup-terraform@v3 - name: Terraform fmt From 521e78597400d2bff4171059223311208257c0d5 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 30 Jan 2024 06:39:26 +0000 Subject: [PATCH 2/4] Bump nock from 13.5.0 to 13.5.1 (#392) Bumps [nock](https://github.com/nock/nock) from 13.5.0 to 13.5.1. - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](https://github.com/nock/nock/compare/v13.5.0...v13.5.1) --- updated-dependencies: - dependency-name: nock dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- package-lock.json | 14 +++++++------- package.json | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index ebf45f5..64e9afa 100644 --- a/package-lock.json +++ b/package-lock.json @@ -20,7 +20,7 @@ "@vercel/ncc": "^0.38.1", "husky": "^8.0.3", "jest": "^29.7.0", - "nock": "^13.5.0", + "nock": "^13.5.1", "semistandard": "^17.0.0" } }, @@ -5194,9 +5194,9 @@ "dev": true }, "node_modules/nock": { - "version": "13.5.0", - "resolved": "https://registry.npmjs.org/nock/-/nock-13.5.0.tgz", - "integrity": "sha512-9hc1eCS2HtOz+sE9W7JQw/tXJktg0zoPSu48s/pYe73e25JW9ywiowbqnUSd7iZPeVawLcVpPZeZS312fwSY+g==", + "version": "13.5.1", + "resolved": "https://registry.npmjs.org/nock/-/nock-13.5.1.tgz", + "integrity": "sha512-+s7b73fzj5KnxbKH4Oaqz07tQ8degcMilU4rrmnKvI//b0JMBU4wEXFQ8zqr+3+L4eWSfU3H/UoIVGUV0tue1Q==", "dev": true, "dependencies": { "debug": "^4.1.0", @@ -10632,9 +10632,9 @@ "dev": true }, "nock": { - "version": "13.5.0", - "resolved": "https://registry.npmjs.org/nock/-/nock-13.5.0.tgz", - "integrity": "sha512-9hc1eCS2HtOz+sE9W7JQw/tXJktg0zoPSu48s/pYe73e25JW9ywiowbqnUSd7iZPeVawLcVpPZeZS312fwSY+g==", + "version": "13.5.1", + "resolved": "https://registry.npmjs.org/nock/-/nock-13.5.1.tgz", + "integrity": "sha512-+s7b73fzj5KnxbKH4Oaqz07tQ8degcMilU4rrmnKvI//b0JMBU4wEXFQ8zqr+3+L4eWSfU3H/UoIVGUV0tue1Q==", "dev": true, "requires": { "debug": "^4.1.0", diff --git a/package.json b/package.json index 196ff79..a161ec9 100644 --- a/package.json +++ b/package.json @@ -30,7 +30,7 @@ "@vercel/ncc": "^0.38.1", "husky": "^8.0.3", "jest": "^29.7.0", - "nock": "^13.5.0", + "nock": "^13.5.1", "semistandard": "^17.0.0" }, "semistandard": { From e12a01440e5748b5091248b30ddcef3ff73cdaf1 Mon Sep 17 00:00:00 2001 From: Austin Valle Date: Wed, 31 Jan 2024 09:24:06 -0500 Subject: [PATCH 3/4] Remove precommit and update dependabot (#393) --- .github/dependabot.yml | 7 +++++++ .husky/.gitignore | 1 - .husky/pre-commit | 4 ---- 3 files changed, 7 insertions(+), 5 deletions(-) delete mode 100644 .husky/.gitignore delete mode 100755 .husky/pre-commit diff --git a/.github/dependabot.yml b/.github/dependabot.yml index aff82a1..49ca66c 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -4,3 +4,10 @@ updates: directory: "/" schedule: interval: "weekly" + # Dependabot only updates hashicorp GHAs, external GHAs are managed by internal tooling (tsccr) + - package-ecosystem: "github-actions" + directory: "/" + schedule: + interval: "daily" + allow: + - dependency-name: "hashicorp/*" diff --git a/.husky/.gitignore b/.husky/.gitignore deleted file mode 100644 index 31354ec..0000000 --- a/.husky/.gitignore +++ /dev/null @@ -1 +0,0 @@ -_ diff --git a/.husky/pre-commit b/.husky/pre-commit deleted file mode 100755 index b8d755f..0000000 --- a/.husky/pre-commit +++ /dev/null @@ -1,4 +0,0 @@ -#!/bin/sh -. "$(dirname "$0")/_/husky.sh" - -npm run build && git add dist/ From 2417443146da980df2e6d7e43c755f97fb5ad93e Mon Sep 17 00:00:00 2001 From: Austin Valle Date: Wed, 31 Jan 2024 14:11:44 -0500 Subject: [PATCH 4/4] Remove husky tool + fix lint error (#394) * remove husky * fix tests --- dist/index1.js | 2 +- package-lock.json | 22 ---------------------- package.json | 2 -- wrapper/terraform.js | 2 +- 4 files changed, 2 insertions(+), 26 deletions(-) diff --git a/dist/index1.js b/dist/index1.js index 56af656..ef4cacc 100755 --- a/dist/index1.js +++ b/dist/index1.js @@ -27222,7 +27222,7 @@ async function checkTerraform () { const options = { listeners, ignoreReturnCode: true, - silent: true, // avoid printing command in stdout: https://github.com/actions/toolkit/issues/649 + silent: true // avoid printing command in stdout: https://github.com/actions/toolkit/issues/649 }; const exitCode = await exec(pathToCLI, args, options); diff --git a/package-lock.json b/package-lock.json index 64e9afa..f159e54 100644 --- a/package-lock.json +++ b/package-lock.json @@ -18,7 +18,6 @@ }, "devDependencies": { "@vercel/ncc": "^0.38.1", - "husky": "^8.0.3", "jest": "^29.7.0", "nock": "^13.5.1", "semistandard": "^17.0.0" @@ -3658,21 +3657,6 @@ "node": ">=10.17.0" } }, - "node_modules/husky": { - "version": "8.0.3", - "resolved": "https://registry.npmjs.org/husky/-/husky-8.0.3.tgz", - "integrity": "sha512-+dQSyqPh4x1hlO1swXBiNb2HzTDN1I2IGLQx1GrBuiqFJfoMrnZWwVmatvSiO+Iz8fBUnf+lekwNo4c2LlXItg==", - "dev": true, - "bin": { - "husky": "lib/bin.js" - }, - "engines": { - "node": ">=14" - }, - "funding": { - "url": "https://github.com/sponsors/typicode" - } - }, "node_modules/ignore": { "version": "5.2.4", "resolved": "https://registry.npmjs.org/ignore/-/ignore-5.2.4.tgz", @@ -9491,12 +9475,6 @@ "integrity": "sha512-B4FFZ6q/T2jhhksgkbEW3HBvWIfDW85snkQgawt07S7J5QXTk6BkNV+0yAeZrM5QpMAdYlocGoljn0sJ/WQkFw==", "dev": true }, - "husky": { - "version": "8.0.3", - "resolved": "https://registry.npmjs.org/husky/-/husky-8.0.3.tgz", - "integrity": "sha512-+dQSyqPh4x1hlO1swXBiNb2HzTDN1I2IGLQx1GrBuiqFJfoMrnZWwVmatvSiO+Iz8fBUnf+lekwNo4c2LlXItg==", - "dev": true - }, "ignore": { "version": "5.2.4", "resolved": "https://registry.npmjs.org/ignore/-/ignore-5.2.4.tgz", diff --git a/package.json b/package.json index a161ec9..e347a3b 100644 --- a/package.json +++ b/package.json @@ -13,7 +13,6 @@ "test": "semistandard --env jest && jest --coverage", "lint": "semistandard --env jest --fix", "build": "ncc build wrapper/terraform.js --out wrapper/dist && ncc build index.js --out dist", - "prepare": "husky install", "format-check": "echo \"unimplemented for actions/reusable-workflows basic-validation\"" }, "keywords": [], @@ -28,7 +27,6 @@ }, "devDependencies": { "@vercel/ncc": "^0.38.1", - "husky": "^8.0.3", "jest": "^29.7.0", "nock": "^13.5.1", "semistandard": "^17.0.0" diff --git a/wrapper/terraform.js b/wrapper/terraform.js index a64a4c2..20fec38 100755 --- a/wrapper/terraform.js +++ b/wrapper/terraform.js @@ -34,7 +34,7 @@ async function checkTerraform () { const options = { listeners, ignoreReturnCode: true, - silent: true, // avoid printing command in stdout: https://github.com/actions/toolkit/issues/649 + silent: true // avoid printing command in stdout: https://github.com/actions/toolkit/issues/649 }; const exitCode = await exec(pathToCLI, args, options);